Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Load test: Fix example yaml config #1634

Merged
merged 1 commit into from
Jun 22, 2020
Merged

Load test: Fix example yaml config #1634

merged 1 commit into from
Jun 22, 2020

Conversation

aLekSer
Copy link
Collaborator

@aLekSer aLekSer commented Jun 22, 2020

Change link to gcr.io/agones-images.

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug
/kind cleanup
/kind documentation
/kind feature
/kind hotfix

What this PR does / Why we need it:

Which issue(s) this PR fixes:

Closes #

Special notes for your reviewer:

@aLekSer
Load test: Fix gcr.io repo name to public
5632286 
Change link to gcr.io/agones-images.
@aLekSer aLekSer changed the title Load test: Fix gcr.io repo name to public Load test: Fix example yaml config Jun 22, 2020
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 7bbeb601-865f-48d0-829f-7d916826cb55

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/1634/head:pr_1634 && git checkout pr_1634
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.7.0-5632286

@google-oss-robot
Copy link

@akremsa: changing LGTM is restricted to collaborators

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akremsa, aLekSer, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roberthbailey roberthbailey merged commit cbf9cdb into googleforgames:master Jun 22, 2020
@aLekSer aLekSer deleted the fix/load-test-yaml branch June 22, 2020 15:01
@markmandel markmandel added this to the 1.7.0 milestone Jun 30, 2020
@markmandel markmandel added area/examples Examples. Usually found in the `examples` directory kind/bug These are bugs. labels Jun 30, 2020
ilkercelikyilmaz pushed a commit to ilkercelikyilmaz/agones that referenced this pull request Oct 23, 2020
@aLekSer @ilkercelikyilmaz
Load test: Fix gcr.io repo name to public (googleforgames#1634)
0dc44eb 
Change link to gcr.io/agones-images.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akremsa akremsa akremsa approved these changes

@roberthbailey roberthbailey roberthbailey approved these changes

@cyriltovena cyriltovena Awaiting requested review from cyriltovena

@EricFortin EricFortin Awaiting requested review from EricFortin

Assignees

@roberthbailey roberthbailey

Labels
approved area/examples Examples. Usually found in the `examples` directory cla: yes kind/bug These are bugs. lgtm size/XS
Projects
None yet
Milestone
1.7.0
Development

Successfully merging this pull request may close these issues.
7 participants
@aLekSer @agones-bot @google-oss-robot @roberthbailey @akremsa @markmandel @googlebot